Block unsupported sync before durable persistence - #40
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e5eac532ea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| return { kind: "continue", taskIdOrProject: arguments_.join(" ") }; | ||
| } | ||
| if (command === "sync") { |
There was a problem hiding this comment.
When the documented form @D-AI sync，然后核实 ... (or an English form such as @D-AI sync, then ...) enters createCodexActivation, whitespace tokenization makes the command token sync，然后核实 rather than sync, so this equality is false. The request consequently falls through as an intent, and executeIntent may create and persist a durable task—the exact side effect this change is intended to prevent. Treat punctuation as a command boundary before preserving the trailing task text.
AGENTS.md reference: AGENTS.md:L7-L7
Useful? React with 👍 / 👎.
1 participant
Summary
@D-AI syncas a dedicated command, including bare sync.Root cause and invariant
Explicit
@D-AIinput bypassed natural-language classification. Becausesyncwas not a parser command, it fell through to generic intent; bootstrap/route/execute/debug/recover then persisted a task before the Codex adapter reported that no bounded verification operation was configured.New invariant: unsupported sync returns
BLOCKEDbefore any durable task selection, discovery, ownership, bootstrap, generation, pointer, or companion-file write. Bare and project-qualified sync preserve this invariant.Scope
src/entry/command-parser.tssrc/runtime/d-ai-runtime.tstests/entry/command-parser.test.tstests/integration/unsupported-sync.test.tsNo actual sync implementation, resolver redesign, fuzzy aliases, project files, installed Skill files, or durable-store redesign.
Verification
git diff --checkand added-line privacy scan: PASS (0 secret-like hits)The real Quote Float canonical task and duplicate durable task were untouched. Duplicate cleanup remains a separate destructive decision. No actual sync was implemented.