Stabilize D-AI-Hub V1 canonical truth - #35
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: afb14b85a2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } else if (!hasStablePrFields) { | ||
| findings.push(...legacyPullRequestFindings(project, lifecycle, currentPr, true)); |
There was a problem hiding this comment.
When an active project's STATUS.md still contains - Current PR: #29 (open), this branch delegates to legacyPullRequestFindings, which returns no finding and does not require the canonical query-only boundary. The health check therefore accepts the mutable live-PR snapshot that the newly added canonical-truth decision requires checkpoints to avoid, allowing stale external state to remain in a supposedly healthy repository; reject Current PR snapshots rather than treating this legacy format as valid.
Useful? React with 👍 / 👎.
1 participant
Summary:\n- Separate private-by-intent product wording from live GitHub visibility and keep mutable PR/CI data query-only.\n- Add the query-only STATUS health contract with rejection of malformed, duplicate, and split legacy fields.\n- No runtime refactor.\n\nVerification:\n- Affected health tests: 10 passed. Broader health regression: 68 passed, 1 skipped.\n- Reused full non-integration: 741 passed, 9 skipped; integration: 49 passed, 1 skipped; typecheck/build passed.\n- Structural index/frontmatter/Markdown checks passed; added-line secret-like scan found 0 matches.\n- Repository visibility remains PUBLIC and unchanged; no private material was added.\n- Merge performed: NO.