Build(deps): Bump postcss from 8.5.19 to 8.5.25 in /vscode - #149
Closed
dependabot[bot] wants to merge 1 commit into
Closed
Build(deps): Bump postcss from 8.5.19 to 8.5.25 in /vscode#149dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [postcss](https://github.com/postcss/postcss) from 8.5.19 to 8.5.25. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.5.19...8.5.25) --- updated-dependencies: - dependency-name: postcss dependency-version: 8.5.25 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
Owner
|
Closing as superseded: the build-test failure here is a pre-existing flaky test on main ( |
Contributor
Author
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
dependabot
Bot
deleted the
dependabot/npm_and_yarn/vscode/postcss-8.5.25
branch
August 5, 2026 05:15
kdr
added a commit
that referenced
this pull request
Aug 5, 2026
… add --all abort test (#152) Closes out the current Dependabot security sweep (https://github.com/kdr/overcast/security/dependabot). ## What - **vscode/package-lock.json (lockfile-only, within existing semver ranges):** - `postcss` 8.5.19 → 8.5.25 — attacker-controlled `sourceMappingURL` reads arbitrary `.map` files when `from` is unset (alert #22; via tsup/vite) - `brace-expansion` 5.0.8 → 5.0.9 — DoS via unbounded intermediate arrays (flagged by `npm audit`, no open Dependabot PR; via `@vscode/vsce` → minimatch) - vscode `npm audit` after: **0 vulnerabilities** - **test/unit/face-index.test.ts:** deterministic abort point for `aborting during add --all backpressure stops before the next wave`. The 100 ms wall-clock abort raced wave 0's child processes under suite load: landing mid-spawn surfaces node's generic `AbortError` (reason demoted to `cause`) instead of `signal.reason`, and wave-0 membership may not be written yet — intermittently failing both assertions (this reddened #149's CI and one local full run). The test now aborts only once the wave-0 member is visibly written, i.e. provably inside the 60 s between-wave settle sleep whose abort path rejects with the reason; if the run settles first the poll bails so the real error surfaces through `assert.rejects`. ## Triage context (same sweep, handled outside this PR) - Merged: #150 (root postcss 8.5.25), #151 (vscode fast-uri 3.1.5) — both green; alerts #21/#23 auto-closed. - Closed: #149 (vscode postcss) as superseded — its only CI failure was the flaky test fixed here; its bump is included here. - Already on main: #147 (vscode undici 7.29.0). ## Not addressed — upstream-blocked (alerts #19, #11–13) Root `brace-expansion@5.0.7` (high) and `undici@8.5.0` (3 medium) are pinned inside `@earendil-works/pi-coding-agent`'s published `npm-shrinkwrap.json`. Root `overrides` and `npm audit fix` silently no-op on the shrinkwrapped subtree (audit even prints "fix available", then changes nothing), and pi-coding-agent 0.83.0 still declares `undici@8.5.0` exactly — the only real fix is an upstream pi release with a refreshed shrinkwrap, then a reviewed exact-pin bump. Interim reachability: pi 0.83.0's undici use has no cache/retry interceptors (the CVE surfaces), and its minimatch patterns are config-driven, not attacker input. ## Verification (all on this branch, full unfiltered output) | suite | result | | --- | --- | | `npm test` | **1319/1319 pass**, exit 0 | | `npm run test:e2e` (offline) | **367/367 passed, 0 failed**, exit 0 | | `npm run typecheck` | exit 0 | | vscode `typecheck` / `build` / `test` / `package` | exit 0 / exit 0 / **56/56** / `.vsix` packaged (vsce = the brace-expansion consumer) | | `npm run test:e2e:live` (compiled **bun binary**) | **767/778 passed, 11 failed** | | live re-run of the 5 failing cases (same binary) | **187/194 passed, 7 failed** — 4 recovered (transient: Apify `x` no-hits, brain-LLM `see` empty responses) | The 7 persistent live failures are external-data conditions, not code: Apify lens actor returning no hits today (4 assertions), `chain:btc` head tx currently **unconfirmed** so `payload.created` is null by design (`chain.sh` maps `status.block_time // null`), and one borderline CLIP text×image ranking. The bun binary under test is content-identical to main's (this diff is vscode-lockfile + a unit test only; root lockfile byte-identical after rebase), so those reflect main's current live status, not this PR. Flake-fix determinism: patched test file green 3×3 isolated runs + full suite green (previously failed the full-suite run). ## Follow-up suggestions (not in this PR) - Watch pi upstream for a shrinkwrap refresh to clear alerts #19/#11–13 via a reviewed pin bump. - The live `20b` chain case could tolerate an unconfirmed head tx (assert `created` only on confirmed txs). <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Lockfile-only dependency patches plus a unit-test timing fix; no production runtime or application logic changes. > > **Overview** > **Dependency updates (vscode lockfile only):** bumps `postcss` to 8.5.25 and `brace-expansion` to 5.0.9 within existing semver ranges to address Dependabot/npm audit findings (source map path handling and minimatch DoS). > > **Test stability:** the `index add --all` backpressure abort test no longer fires `AbortController` after a fixed 100ms. It waits until wave 0 has written at least one index member (or the run settles), so abort happens during the long between-wave `sleep` where rejection uses `signal.reason`, avoiding flaky `assert.rejects` and wrong member counts under full-suite load. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 836b3fb. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps postcss from 8.5.19 to 8.5.25.
Release notes
Sourced from postcss's releases.
Changelog
Sourced from postcss's changelog.
Commits
08c989cRelease 8.5.25 version24f6814Fix 8.5.17 visitor regressionf2fa53fAdd supply chain security requirement to PostCSS plugin guide10edf0bfix: return empty array for empty string in list.split (#2121)0ebe8adRelease 8.5.24 version73218c6Update dependencies9a114f6Preserve the BOM when stringifying (#2119)9069261Fix types checkeb9e1feRelease 8.5.23 version9d19c78Update dependenciesDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.
Note
Low Risk
Patch-level dev dependency lockfile change with no application code touched; minor postcss fixes including a source-map loading hardening in 8.5.23.
Overview
Lockfile-only update in
vscode/package-lock.json: resolved postcss moves from 8.5.19 to 8.5.25 (dev dependency), and postcss’s nanoid dependency range resolves to ^3.3.16.No source or config changes in the repo—only the pinned transitive versions for the VS Code extension’s npm tree.
Reviewed by Cursor Bugbot for commit 3ad2f96. Bugbot is set up for automated code reviews on this repo. Configure here.