Empty-@context fixture must leave the no-filter green path - #30
Open
forest-savage1234 wants to merge 1 commit into
Open
Empty-@context fixture must leave the no-filter green path#30forest-savage1234 wants to merge 1 commit into
forest-savage1234 wants to merge 1 commit into
Conversation
Signed-off-by: Forest Savage <forestsavage03@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty-@context fixture must leave the no-filter green path
tests/data/no-context.jsonis{"@context": {}}with compact CURIEs (uco-identity:Organization). The CI job "Directory No Filter" validates./tests/data/, so this file is on the green path and is reported as conforming. Unexpanded CURIEs are not CDO HTTPS IRIs, so CDO/SHACL checks do not bind.This packet moves that fixture to
tests/negative/so the no-filter job no longer validates it. The JSON is unchanged. The validator is unchanged. The CASE 1.4.0 pin is KNOWN and stays. The empty-directory walk is C5.Files
tests/data/no-context.json→tests/negative/no-context.json(rename only).github/workflows/validate.yml— one-line comment on the no-filter stepOut of scope
fileslist still exits 0)case-1.5.0(KNOWN)entrypoint.pyHow to review
The dest is that the fixture is no longer under
tests/data/. The no-filter job still points at./tests/data/. The JSON bytes are the same.I am a volunteer. Thank you for the time. I am trying to become more useful on this work, so I welcome a critical look. If this is the wrong cut, or you want me to stand down, say so and I will recut from notes.