Repository navigation
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the GFF schema’s required-field naming correction.
No open issues 🎉
What changed in this PR
Corrects the GFF schema’s required field name to match its existing seqid property, resolving the validation failure described in #385.
Changes:
- Replaces
sequidwithseqidin the schema’srequiredlist.
| File | Description |
|---|---|
src/cdm_data_loaders/schemas/gff/gff.schema.json |
Fixes the required field name so valid GFF rows are not rejected for a missing sequid property. |
Review effort: Balanced
|
Hi @ialarmedalien how do you feel about fork PRs like this in this repo? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #386 +/- ##
========================================
Coverage 96.85% 96.85%
========================================
Files 173 173
Lines 12036 12036
========================================
Hits 11657 11657
Misses 379 379 Continue to review full report in Codecov by Harness.
|
Description of PR purpose/changes
Line 98 of the GFF schema's
requiredlist saidsequid, which doesn't match theseqidproperty on line 7. This changes it toseqid.Closes #385
Testing Instructions
What was run on develop (a59b4d1) and on this branch, and what happened:
uv run pytest tests/cdm_data_loaders/schemas, the new test, which checks that every name in a bundled schema'srequiredlist is one of itsproperties. On develop, the GFF schema fails and the other 11 bundled schemas pass. On this branch, all 12 pass.qsv validate --split-ragged --trim(qsv 29.0.0) on the Populus trichocarpa v4.1 GFF, 730,996 rows. On develop, every row fails with "sequid is a required property". On this branch, every row passes.uv run ruff format --check,uv run ruff checkon the changed files, anduv run pytest -m docs. All pass.Dev Checklist:
gff.schema.json, wrote the test, wrote most of this description, and ran the new test, ruff and the docs tests. I ran the Populus check myself.