Skip to content

Change sequid to seqid in the GFF schema's required list - #386

Open
turbomam wants to merge 4 commits into
kbase:developfrom
turbomam:fix-gff-required-seqid
Open

turbomam wants to merge 4 commits into
kbase:developfrom
turbomam:fix-gff-required-seqid

Conversation

@turbomam

@turbomam turbomam commented Nov 20, 2026 •

Copy link
Copy Markdown

Description of PR purpose/changes

Line 98 of the GFF schema's required list said sequid, which doesn't match the seqid property on line 7. This changes it to seqid.

Closes #385

Testing Instructions

What was run on develop (a59b4d1) and on this branch, and what happened:

  • uv run pytest tests/cdm_data_loaders/schemas, the new test, which checks that every name in a bundled schema's required list is one of its properties. On develop, the GFF schema fails and the other 11 bundled schemas pass. On this branch, all 12 pass.
  • qsv validate --split-ragged --trim (qsv 29.0.0) on the Populus trichocarpa v4.1 GFF, 730,996 rows. On develop, every row fails with "sequid is a required property". On this branch, every row passes.
  • uv run ruff format --check, uv run ruff check on the changed files, and uv run pytest -m docs. All pass.

Dev Checklist:

  • My submission follows the AI Covenant principles
    • Claude made the edit to gff.schema.json, wrote the test, wrote most of this description, and ran the new test, ruff and the docs tests. I ran the Populus check myself.
  • I have performed a self-review of my own code

Copilot AI balanced review requested due to automatic review settings November 20, 2026 15:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the GFF schema’s required-field naming correction.

No open issues 🎉

What changed in this PR

Corrects the GFF schema’s required field name to match its existing seqid property, resolving the validation failure described in #385.

Changes:

  • Replaces sequid with seqid in the schema’s required list.
File Description
src/​cdm_data_loaders/​schemas/​gff/​gff.schema.json Fixes the required field name so valid GFF rows are not rejected for a missing sequid property.

Review effort: Balanced

@turbomam

turbomam commented Nov 20, 2026 •

Copy link
Copy Markdown
Author

Hi @ialarmedalien how do you feel about fork PRs like this in this repo?

@codecov

codecov Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.85%. Comparing base (2f53afe) to head (2f5ab71).
⚠️ Report is 1 commits behind head on develop.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #386   +/-   ##
========================================
  Coverage    96.85%   96.85%           
========================================
  Files          173      173           
  Lines        12036    12036           
========================================
  Hits         11657    11657           
  Misses         379      379           

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65b7707...2f5ab71. Read the comment docs.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GFF schema required list says sequid, but the property is named seqid

3 participants