Skip to content

Convert a set of dataclasses to Pydantic classes - #383

Merged
ialarmedalien merged 2 commits into
developfrom
down_dataclasses
Nov 20, 2026
Merged

ialarmedalien merged 2 commits into
developfrom
down_dataclasses

Conversation

@ialarmedalien

Copy link
Copy Markdown
Collaborator

Remove unnecessary validation stuff


type _TableSchemaField = Annotated[
TTableSchema,
GetPydanticSchema(lambda _tp, _handler: core_schema.is_instance_schema(Mapping)),
from cdm_data_loaders.utils.recursion import DEFAULT_MAX_RECURSION_DEPTH
type _ModuleNamespace = Annotated[
Mapping[str, Any],
GetPydanticSchema(lambda _tp, _handler: core_schema.is_instance_schema(Mapping)),

type _LoadInfoField = Annotated[
LoadInfo,
GetPydanticSchema(lambda _tp, _handler: core_schema.is_instance_schema(LoadInfo)),
@dataclass(frozen=True, slots=True)
type _MappingInstance[K, V] = Annotated[
Mapping[K, V],
GetPydanticSchema(lambda _tp, _handler: core_schema.is_instance_schema(Mapping)),

type _StructCacheField = Annotated[
dict[tuple[int, bool], Any],
GetPydanticSchema(lambda _tp, _handler: core_schema.is_instance_schema(dict)),
from lxml.etree import XMLParser, fromstring

import cdm_data_loaders.datasets.uniprot.kb as uniprot_kb_module
import cdm_data_loaders.datasets.uniprot.uniprot_kb as uniprot_kb_module
@codecov

codecov Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.08537% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.85%. Comparing base (ec059cd) to head (2f53afe).
⚠️ Report is 1 commits behind head on develop.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/cdm_data_loaders/converters/core/ir.py 96.66% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #383      +/-   ##
===========================================
- Coverage    96.88%   96.85%   -0.04%     
===========================================
  Files          173      173              
  Lines        12079    12036      -43     
===========================================
- Hits         11703    11657      -46     
- Misses         376      379       +3     
Files with missing lines Coverage Δ
..._data_loaders/converters/core/dlt_normalization.py 100.00% <100.00%> (ø)
src/cdm_data_loaders/converters/core/errors.py 100.00% <100.00%> (ø)
src/cdm_data_loaders/converters/core/extensions.py 97.77% <100.00%> (+0.05%) ⬆️
src/cdm_data_loaders/converters/core/ir_values.py 100.00% <100.00%> (ø)
src/cdm_data_loaders/converters/core/metadata.py 100.00% <100.00%> (ø)
..._data_loaders/converters/emitters/_tabular_base.py 94.76% <100.00%> (ø)
src/cdm_data_loaders/converters/emitters/dlt.py 100.00% <100.00%> (ø)
...loaders/converters/emitters/json_schema/emitter.py 100.00% <100.00%> (ø)
src/cdm_data_loaders/converters/emitters/linkml.py 100.00% <100.00%> (ø)
src/cdm_data_loaders/converters/facades/_base.py 97.87% <ø> (ø)
... and 27 more

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a59b4d1...2f53afe. Read the comment docs.

@ialarmedalien
ialarmedalien merged commit 65b7707 into develop Nov 20, 2026
25 of 26 checks passed
@ialarmedalien
ialarmedalien deleted the down_dataclasses branch November 20, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant