Skip to content

More reorg - #381

Merged
ialarmedalien merged 2 commits into
developfrom
more_reorg
Nov 18, 2026
Merged

ialarmedalien merged 2 commits into
developfrom
more_reorg

Conversation

@ialarmedalien

Copy link
Copy Markdown
Collaborator

No description provided.


DEFAULT_ENTRY_TABLE_NAME: Final[str] = "entry"
UNIPROT_CURIE_NAMESPACE: Final[str] = "uniprot"
UNIPROT_CURIE_PREFIX: Final[str] = f"{UNIPROT_CURIE_NAMESPACE}:"
UNIPROT_CURIE_NAMESPACE: Final[str] = "uniprot"
UNIPROT_CURIE_PREFIX: Final[str] = f"{UNIPROT_CURIE_NAMESPACE}:"
UNIREF_CURIE_NAMESPACE: Final[str] = "uniref"
UNIREF_CURIE_PREFIX: Final[str] = f"{UNIREF_CURIE_NAMESPACE}:"
# Extracts the database (GCF or GCA) and 3-digit parts from an accession ID
ACCESSION_PARTS_REGEX: Final[re.Pattern[str]] = re.compile(r"(GC[AF])_(\d{3})(\d{3})(\d{3})\.\d+.*")
# Matches a bare accession (GCF_000001215.4) or an assembly directory name (GCF_000001215.4_Release_6...)
ACCESSION_PARTS_REGEX: Final[re.Pattern[str]] = re.compile(
)

# Matches an assembly directory name with a required suffix after the versioned accession
ASSEMBLY_DIR_REGEX: Final[re.Pattern[str]] = re.compile(r"^(?P<accession>GC[AF]_\d{9}\.\d+)_(?P<name>[^/]+)$")
# Extracts the full assembly directory, accession, and database (GCA or GCF) from an FTP path
ASSEMBLY_PATH_REGEX: Final[re.Pattern[str]] = re.compile(r"(((GC[AF])_\d{9}\.\d+)_[^/]+)/?.*$")
# Extracts the assembly directory, accession, and database (GCA or GCF) from an FTP or S3 path
ASSEMBLY_PATH_REGEX: Final[re.Pattern[str]] = re.compile(
@codecov

codecov Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.90%. Comparing base (8db1f30) to head (8012d7d).
⚠️ Report is 1 commits behind head on develop.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #381      +/-   ##
===========================================
+ Coverage    95.47%   96.90%   +1.43%     
===========================================
  Files          174      174              
  Lines        12053    12151      +98     
===========================================
+ Hits         11507    11775     +268     
+ Misses         546      376     -170     
Files with missing lines Coverage Δ
...rc/cdm_data_loaders/cli/ncbi_ftp_filter_updates.py 98.52% <100.00%> (+98.52%) ⬆️
...oaders/converters/facades/jsonschema_to_pyarrow.py 89.18% <ø> (-0.15%) ⬇️
src/cdm_data_loaders/core/buffer.py 100.00% <100.00%> (ø)
src/cdm_data_loaders/core/filesystem.py 100.00% <100.00%> (ø)
src/cdm_data_loaders/core/transforms/hints.py 100.00% <100.00%> (ø)
src/cdm_data_loaders/core/transforms/routing.py 98.75% <100.00%> (-0.01%) ⬇️
...cdm_data_loaders/core/transforms/settings_mixin.py 97.27% <100.00%> (+0.43%) ⬆️
.../cdm_data_loaders/datasets/all_the_bacteria/osf.py 100.00% <100.00%> (ø)
src/cdm_data_loaders/datasets/ncbi_ftp/assembly.py 100.00% <100.00%> (+7.04%) ⬆️
...rc/cdm_data_loaders/datasets/ncbi_ftp/constants.py 100.00% <100.00%> (ø)
... and 27 more

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 808b757...8012d7d. Read the comment docs.

@ialarmedalien
ialarmedalien merged commit 8012d7d into develop Nov 18, 2026
24 of 26 checks passed
@ialarmedalien
ialarmedalien deleted the more_reorg branch November 18, 2026 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant