Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
An agent that only needs to write or update a blueprint had to load
dispatch:design(a whole design conversation) ordispatch:design-review(a whole review), and neither held all the rules. They now live in one skill:Design and design-review load it where they used to state the rules. This is an extraction. No rule or outline section was added, dropped or changed in meaning.
Implementation
skills/blueprint/SKILL.mdwith the outline, saving rules, PII,TODO:and[NEEDS CLARIFICATION: ...]markers, run records, the domain-boundary statement, the OpenAPI second document and spec check,Glossary changes, the unnumberedADR: <title>section, and the read-and-patch rules with the Decision Log entry for review answers.skills/design/SKILL.mdloadsdispatch:blueprintat Start; its "Write the blueprint" section now points to it and keeps the draft-save cadence.skills/design-review/SKILL.mdloads it at the top; its reading, glossary, ADR and contract steps point to it.CONTEXT-FORMAT.mdstays inskills/design/; the new skill links../design/CONTEXT-FORMAT.md, so the three existing links are unchanged.Calls on the borderline text:
[NEEDS CLARIFICATION: ...], draft saving after each phase, the domain-boundary checks.blueprint.mdcopy for sub-agents, offering an ADR,duh lint, "add nothing for dismissed findings". Soft-flag consumers (Pre-work, Phase 4) still spell out the marker.skills/design-adr-audit/SKILL.mdandskills/design-fit-review/SKILL.mdalso restate the scratchpad-copy rule.Verification
make testpasses. No evals were run, as asked. A fresh sub-agent loadedanthropic-skills:skill-creatorand reviewed the skill without test prompts. I fixed what it found: design-review lacked a load line, the patch-only rule reached design's draft saves, the Decision Log entry was not scoped to review, "soft flags" was undefined, and the description under-triggered. Perspectives not used: a second independent lens on rule-meaning drift.Suggestions from the review that change a rule, left for you: say which section a run's record goes in; place "We considered X but chose Y because Z" in the Decision Log;
Pieces(added by breakdown) is not in the outline.Fixes ENG-591