Repository navigation
Stop prescribing a build tag for slow tests - #200
Merged
thrawn01 merged 1 commit intoOct 30, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Workers were told they could tag a slow test
tests_slowwithout asking. In the user's Bazel mono-repo, changing a test's tag made Bazel rebuild and rerun the whole suite, so one tag edit cost a full run. A rule that fits dispatch's repo was applied to codebases it doesn't fit.After this change
grep -r tests_slow skills/prints nothing. A test still over 1 second now follows the codebase's own way of handling slow tests, and a worker is told not to invent one. The 1 second per test and 5 minutes per suite budget is unchanged.Implementation
skills/build/SKILL.mddrops the standing exception that let a worker tag a test without quoting the user.skills/principle-fast-tests/SKILL.mdreplaces the tag paragraph with "follow the codebase's own way; if it has none, leave the test and report its time and what you tried". It also loses "tagging" from the description and-tags tests_slowfrom thetest-reportline.skills/surface-testing/SKILL.mdandskills/repo-targets/SKILL.mdlose the tag pointers, thetest-slowrow and the "add targets before tagging" sentence.tests_slowtag stays.CLAUDE.md,README.md, the Makefile, CI,cmd/slowtests,internal/slowtestsand the tagged tests are untouched, so those still describe the tag for this repo.Verification: ran
grep -r tests_slow skills/(empty). No evals, per the ticket. A fresh sub-agent loadedskill-creatorand reviewed the changed skills without test prompts. I took its wording fix (report "what you tried", not "why it can't be faster") and left its suggestions to trim unrelated existing lines. No Go code changed, so I ran no tests.Fixes ENG-589