Skip to content

Drop code locations from the external tools ADR - #195

Merged
thrawn01 merged 1 commit into
mainfrom
thrawn01/eng-577-drop-code-locations-from-the-external-tools-adr
Oct 27, 2026
Merged

thrawn01 merged 1 commit into
mainfrom
thrawn01/eng-577-drop-code-locations-from-the-external-tools-adr

Conversation

@thrawn01

Copy link
Copy Markdown
Contributor

Purpose

The 2026-10-22 note in ADR 0001 pinned each program dispatch runs outside a port to file paths and line numbers. That list goes stale whenever code moves, and the stacked tickets design (ENG-568) adds git callers to it. ADRs should record decisions and reasons, not where things live, so the note keeps the former and drops the latter.

Before: git has no port ... (teardown_test.go:795) ... runs git in these places: the tree checks ... (internal/treehouse/treehouse.go:157-262)
After: git has no port and no fake. Test cases run real git on the trees under test, and a fake would force edits to those tests.

Implementation

  • Note keeps git, dispatch claude-shim, the Linear key lookup, tsc, gh, alerts, the sh -c <token_command> exception and the test-tooling exclusion, each with the reason it gave before.
  • Removed every path, line number, test name and function name, the git call-site sub-bullets, the per-package list of what test tools run, the "as of this note's date" sentence and the appended rename line.
  • delivery.Alerts and deliverytest read notify.Alerts and notifytest in the Decision and the note; both exist on main.
  • Decision meaning, Consequences and Status are unchanged.

Verified by grepping the file for .go, :<digits> and delivery (no hits) and checking internal/notify and internal/notifytest exist. No code changed, so no tests were run. No sub-agent review rounds, since the change is a deletion-only edit to one document.

Fixes ENG-577

@thrawn01
thrawn01 merged commit 84b0df1 into main Oct 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant