Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
The 2026-10-22 note in ADR 0001 pinned each program dispatch runs outside a port to file paths and line numbers. That list goes stale whenever code moves, and the stacked tickets design (ENG-568) adds git callers to it. ADRs should record decisions and reasons, not where things live, so the note keeps the former and drops the latter.
Before:
git has no port ... (teardown_test.go:795) ... runs git in these places: the tree checks ... (internal/treehouse/treehouse.go:157-262)After:
git has no port and no fake. Test cases run real git on the trees under test, and a fake would force edits to those tests.Implementation
dispatch claude-shim, the Linear key lookup,tsc, gh, alerts, thesh -c <token_command>exception and the test-tooling exclusion, each with the reason it gave before.delivery.Alertsanddeliverytestreadnotify.Alertsandnotifytestin the Decision and the note; both exist on main.Verified by grepping the file for
.go,:<digits>anddelivery(no hits) and checkinginternal/notifyandinternal/notifytestexist. No code changed, so no tests were run. No sub-agent review rounds, since the change is a deletion-only edit to one document.Fixes ENG-577