Prepare Retriable 4.0.0 by removing timeout#134
Merged
Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
kamui
force-pushed
the
4.0.0-remove-timeout
branch
from
6fcca2d to
356bba8
Compare
kamui
force-pushed
the
4.0.0-remove-timeout
branch
from
356bba8 to
de75037
Compare
BREAKING CHANGES:
* Remove the built-in `timeout:` option from `Retriable.retriable`
and `Retriable.with_override`. Passing `timeout:` to those APIs now
raises `ArgumentError`. The `timeout` config attribute has also been
removed, so `Retriable.configure { |c| c.timeout = 5 }` now raises
`NoMethodError`. The option was deprecated in Retriable 3.8.0 and
wrapped Ruby's unsafe `Timeout.timeout`. See issue #96 and the README
migration guide for replacement patterns.
* Drop Ruby < 3.0. The gem now requires Ruby >= 3.0 and the CI matrix
has been trimmed accordingly. Ruby 2.3.0-2.7.x users should stay on
the 3.8.x branch.
* Set `.rubocop.yml` `TargetRubyVersion` to 3.0 and disable a few
gemspec-policy cops that are out of scope for this PR.
* Replace the Ruby 2-compatible `pattern.all? { |p| p.is_a?(Regexp) }`
with Ruby 3's `pattern.all?(Regexp)` in `Retriable::Validation`,
removing the now-unnecessary RuboCop suppression.
* Disable Hound's Ruby checker. Hound's bundled RuboCop cannot parse
the Ruby 3.0 config (unrecognized cops, unsupported
`TargetRubyVersion`), so it fails the PR with a config parse error
rather than producing useful feedback.
kamui
force-pushed
the
4.0.0-remove-timeout
branch
from
de75037 to
a79f3e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
timeout:option and itsTimeout.timeoutwrapper.Test Plan
bundle exec rspecbundle exec rubocopgem build retriable.gemspeclib/