remove base64_encode/decode of the payload.#78
Conversation
Google pub/sub lib already doing this.
|
Thank you for the contribution. Even if it not a huge library, it will break for existing users (there is no major version yet). I feel like it would be better to use the |
|
@kainxspirits It's just an internal flag, because Google pub/sub lib could use 2 types of transport, http or grpc. And encode will always be true for the default http transport. Also with current approach the message size is much bigger than expected. Encoding message with Also, it's worth mentioning the potential release version. [https://getcomposer.org/doc/articles/versions.md#caret-version-range-] So, even if the next version will be 0.10.0 the Obviously, the release is up to you. Just wanted to highlight the problem I found using this lib. |

Google lib, which is used underneath is already properly encoding/decoding the payload. There is no need to do it twice.
Here is some screenshots with the proofs :)
Feel free to dive into the google pub/sub lib and check it on your own :)
As it is the non-compatible change, i suggest bumping up major version during releasing