feat(settings): show attention indicator on tabs and update cards - #115
Merged
kahme247 merged 4 commits intoSep 19, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When an OMP version update (or app self-update) is available, the Settings gear button in the sidebar displays an attention dot. However, navigating into Settings previously showed no indication of why attention was needed or which section to look at.
This PR treats the attention dot as a generic signal and propagates it to:
SettingsTabs): adds anattentionTabs?: Partial<Record<SettingsTab, boolean | string>>prop. Renders a matching accent attention dot on the tab icon (in both vertical and horizontal mobile layouts) with accessible name /role="status"announcements.SettingsConfig): adds the attention dot next to the "OMP CLI & Runtime" and "omp-web Desktop & UI" card headings along with accented border styling when an update is available.ompUpdateAvailabledown fromAppShelltoSettingsConfigso the System tab immediately reflects attention status upon opening.Test Plan
SettingsTabsrendering withattentionTabspresent and omitted (SettingsTabs.test.mjs).aria-labelandrole="status"accessibility attributes on both layouts.tsc --noEmitand linter withnpm run lint.