test: isolate systemd install from host OMP_WEB_OMP_BIN - #108
Merged
Merged
Conversation
Install persists OMP_WEB_OMP_BIN when set. The LAN-settings test copied process.env and leaked the host value into the written service env file.
Contributor
Author
|
Companion review PR (same diff): andrebrait#29 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
npm teston upstreammainfails locally when the host exportsOMP_WEB_OMP_BIN(omp-web itself does this).installcorrectly persists that path intoweb-service.env. The LAN-settings test copiedprocess.envand then asserted a closed env map, so the host value leaked into the assertion.Change
Delete
OMP_WEB_OMP_BINfrom the child env, matching the existingPI_CODING_AGENT_DIRisolation. Product code unchanged.Verification
install creates the env file and unit with LAN settingsfails with extraOMP_WEB_OMP_BIN.tsc --noEmitandeslintclean.