Skip to content

test: Resolve MemoryHub E2E URL from discovery endpoint #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rdwj wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test: Resolve MemoryHub E2E URL from discovery endpoint #243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 27 additions & 7 deletions apps/adk-server/tests/e2e/examples/agent-integration/memoryhub/test_memoryhub_recall.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,17 @@
# SPDX-License-Identifier: Apache-2.0

# Maintainer note: this E2E test requires a reachable MemoryHub instance.
# Add the following repository secrets so CI runs the test:
# MEMORYHUB_E2E_URL (required) — public MemoryHub MCP URL
# MEMORYHUB_E2E_API_KEY (one of) — static API key
# MEMORYHUB_E2E_AUTH_URL (or…)
#
# URL resolution order:
# 1. MEMORYHUB_E2E_URL env var / repo secret (explicit override)
# 2. MemoryHub discovery endpoint (auto-detects current sandbox URL)
#
# Credentials (at least one set required):
# MEMORYHUB_E2E_API_KEY — static API key
# MEMORYHUB_E2E_AUTH_URL — OAuth 2.1 credentials (all three)
# MEMORYHUB_E2E_CLIENT_ID
# MEMORYHUB_E2E_CLIENT_SECRET — OAuth 2.1 credentials
# MEMORYHUB_E2E_CLIENT_SECRET
#
# When neither credential set is configured the test skips cleanly so
# contributor forks don't fail on a missing secret.
#
Expand Down Expand Up @@ -50,9 +55,23 @@

pytestmark = pytest.mark.e2e

DISCOVERY_URL = "https://redhat-ai-americas.github.io/memory-hub/discovery.json"


def _discover_url(timeout: float = 5.0) -> str | None:
"""Fetch the current MCP URL from the MemoryHub discovery endpoint."""
try:
resp = httpx.get(DISCOVERY_URL, timeout=timeout)
resp.raise_for_status()
data = resp.json()
default = data.get("default", "sandbox")
return data["instances"][default]["mcp_url"]
except Exception:
return None


def _fulfillment_from_secrets() -> MemoryHubFulfillment | None:
url = os.environ.get("MEMORYHUB_E2E_URL")
url = os.environ.get("MEMORYHUB_E2E_URL") or _discover_url()
if not url:
return None
api_key = os.environ.get("MEMORYHUB_E2E_API_KEY")
Expand Down Expand Up @@ -135,7 +154,8 @@ async def test_memoryhub_recall_example(subtests, get_final_task_from_stream, a2
fulfillment = _fulfillment_from_secrets()
if fulfillment is None:
pytest.skip(
"MemoryHub E2E secrets not configured (set MEMORYHUB_E2E_URL plus MEMORYHUB_E2E_API_KEY or the OAuth trio)."
"MemoryHub E2E not configured: no MEMORYHUB_E2E_URL set, discovery endpoint unreachable, "
"and/or no credentials (MEMORYHUB_E2E_API_KEY or OAuth trio)."
)

await _xfail_on_backend_drift(fulfillment)
Expand Down