Repository navigation
Maintain fork release branches and unify publishing - #106
Merged
Merged
Conversation
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
EItanya
marked this pull request as ready for review
October 30, 2026 13:31
Signed-off-by: Eitan Yarmush <eitan.yarmush@solo.io>
jjamroga
approved these changes
Oct 30, 2026
Comment on lines
+132
to
+146
| if strings.Contains(notes, "## Images") != tc.artifacts || strings.Contains(notes, "## kubectl-ate") != tc.artifacts { | ||
| t.Fatalf("incorrect artifact notes:\n%s", notes) | ||
| } | ||
| if strings.Contains(notes, "## Helm charts") != (tc.repo == "kagent-dev/substrate") { | ||
| t.Fatalf("incorrect chart notes:\n%s", notes) | ||
| } | ||
| if tc.artifacts { | ||
| repo := tc.registry | ||
| if repo == "" { | ||
| repo = "ghcr.io/" + tc.repo | ||
| } | ||
| if !strings.Contains(notes, "--image-repo "+repo+" --image-tag v1.0.0") { | ||
| t.Errorf("incorrect install image repository:\n%s", notes) | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
Nit: I had to read the code a few times to understand what we're testing here, especially around here
Author
There was a problem hiding this comment.
We should generally clean up testing later, some of them make no sense
This was referenced Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #105. The fork needs to keep its patches on maintained release branches and publish those branches through the same release process.
Expand the sync skill to cover matching upstream branches, release cutoffs, and selective backports while preserving fork changes. Replace
release-forkwith the upstreamreleaseworkflow, enabled for our GHCR namespace with the correct OCI source labels. Publish all three Helm charts before drafting the release, alongside the existing image checks andkubectl-atebinaries.Manual releases now require an existing version tag. Published artifacts remain protected from reruns, and releases do not move the shared image
latesttag. The workflow and publisher changes must be included in the commit being tagged.Validation: focused race tests passed with
-count=3 -shuffle=on; focused golangci-lint, actionlint, shellcheck, formatting, license headers, and Helm packaging/rendering passed. A mutation check confirmed the source-label test fails if the upstream URL is restored. The skill passed its validator and an independent scenario review.AI use: Codex implemented the changes, ran validation, and performed an independent review.
Fork release flow
flowchart LR tag["Release tag"] --> images["Build and verify images"] images --> charts["Publish Helm charts"] charts --> binaries["Build kubectl-ate"] binaries --> draft["Create draft release"] draft --> attach["Attach binaries and checksums"]