feat: add support for containerized environments (DDEV, Lando, Docker)#70
Open
tsega wants to merge 1 commit into
Open
feat: add support for containerized environments (DDEV, Lando, Docker)#70tsega wants to merge 1 commit into
tsega wants to merge 1 commit into
Conversation
Updates the PHPCS, PHPCBF, and PHPStan providers to better support running tools via container wrappers like DDEV, Lando, and Docker. Key changes: - execution: Uses relative file paths instead of absolute paths for linters, ensuring compatibility when host and container paths differ. - execution: Sets the Current Working Directory (cwd) to the workspace root for all spawned processes. - logic: improved detection of wrapper commands (commands with arguments) in the `executablePath` setting. - phpcs: Prioritizes valid JSON output over stderr noise, preventing false failures when wrappers print status messages. - phpcbf: Treats exit code 1 as a success state (errors fixed) and ignores wrapper stderr output if formatting was successful. - tests: Added test cases for container wrapper scenarios, relative paths, and exit code handling.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the PHPCS, PHPCBF, and PHPStan providers to better support running tools via container wrappers like DDEV, Lando, and Docker.
Key changes:
executablePathsetting.