WIP: Api tweaks

.golangci.yml

@@ -34,10 +34,14 @@ linters:
         settings:
           linters:
             disable:
+              # NOTE: conflicts with the lack of validation in the Status structs
+              - arrayofstruct
+              # NOTE: The following checks are currently failing
               - optionalfields
             enable:
               - commentstart
               - conditions
+              - defaults
               - duplicatemarkers
               - integers
               - jsontags
@@ -48,6 +52,7 @@ linters:
               - nodurations
               - nofloats
               - nomaps
+              - nonpointerstructs
               - nonullable
               - notimestamp
               - nophase
@@ -62,11 +67,14 @@ linters:
               isFirstField: Warn
               usePatchStrategy: Ignore
               useProtobuf: Forbid
+            defaults:
+              # Let's use `+kubebuilder:default` until elastic/crd-ref-docs supports `+default`
+              preferredDefaultMarker: "kubebuilder:default"
             requiredfields:
               omitempty:
                 policy: Ignore
   exclusions:
-    generated: lax
+    generated: disable
     rules:
       - linters:
           - lll
@@ -75,13 +83,22 @@ linters:
           - dupl
           - lll
         path: internal/*
+      - linters:
+        - dupl
+        - goimports
+        - unparam
+        path: zz_generated
       - linters:
           - kubeapilinter
-        path-except: api/*
+        path-except: ^api/*
     paths:
       - third_party$
       - builtin$
       - examples$
+      - applyconfiguration/*
+      - clientset/*
+      - informers/*
+      - listers/*
 formatters:
   enable:
     - gofmt
@@ -92,3 +109,5 @@ formatters:
       - third_party$
       - builtin$
       - examples$
+issues:
+  exclude-generated: disable

Makefile

@@ -315,7 +315,7 @@ KUSTOMIZE_VERSION ?= v5.6.0
 CONTROLLER_TOOLS_VERSION ?= v0.17.1
 ENVTEST_VERSION ?= release-0.22
 GOLANGCI_LINT_VERSION ?= v2.7.2
-KAL_VERSION ?= v0.0.0-20250924094418-502783c08f9d
+KAL_VERSION ?= v0.0.0-20260114104534-18147eee9c49
 MOCKGEN_VERSION ?= v0.5.0
 KUTTL_VERSION ?= v0.24.0
 GOVULNCHECK_VERSION ?= v1.1.4

api/v1alpha1/image_types.go

@@ -267,8 +267,7 @@ type ImageContent struct {
 	// download describes how to obtain image data by downloading it from a URL.
 	// Must be set when creating a managed image.
 	// +required
-	//nolint:kubeapilinter
-	Download *ImageContentSourceDownload `json:"download"`
+	Download *ImageContentSourceDownload `json:"download,omitempty"`
 }
 
 type ImageContentSourceDownload struct {

api/v1alpha1/router_interface_types.go

@@ -36,8 +36,8 @@ type RouterInterface struct {
 	metav1.ObjectMeta `json:"metadata,omitempty"`
 
 	// spec specifies the desired state of the resource.
-	// +optional
-	Spec RouterInterfaceSpec `json:"spec,omitempty"`
+	// +required
+	Spec RouterInterfaceSpec `json:"spec,omitzero"`
 
 	// status defines the observed state of the resource.
 	// +optional