Conversation
Introduce `CacheResolver` and `CacheSource` to provide a clear, fixed-precedence cache root resolution mechanism with no silent CWD fallback by default. Update tests, workflows, and documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added
CacheResolver+CacheSource: combined cache-root resolution with fixedprecedence (explicit path → env var → Cargo workspace discovery → OS user
cache) and no silent
<cwd>/.cachescattering. Unresolvable configurationsreturn
Err(NotFound)naming the env var / OS identity that would fix it;the
<cwd>/.cachelast resort is an explicitallow_cwd_fallbackopt-in.The winning source is always returned so binaries can announce cache
placement. Includes resolver unit tests (precedence matrix,
NotFounddefaults, panic-safe env guards) and a README section documenting the
contract and the announce-the-winner convention.
Fixed
from_project_dirsfailed under default features(
directoriesunavailable, method compiled out). Examples are nowfeature-gated
run()functions: fully compiled and executed wherever theos-cache-dirfeature is enabled, neverignored, never stale.