Open
Conversation
|
Hello, it's great to learn about this project. I made some minor improvements. How could I make a pull request? Thanks! |
Author
|
I think to create a pull request, you first make a fork of my project, make changes on a branch in your fork, then the branch can be submitted as a PR to my project.
Ken
On Fri, Feb 19, 2021 at 7:33 PM, madcpf<notifications@github.com> wrote:
Hello, it's great to learn about this project. I made some minor improvements. How could I make a pull request? Thanks!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
make cscore limit and escore limit effective under guided mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I took my wife's favorite portrait of our dog and had it turned into a 1000 piece puzzle for Christmas 2018. The shallow depth of field in the photo means the background doesn't have much detail. I quickly realized that I would need help to finish solving it, searched around and found PuzzleSolver. Over the past few months I have made improvements that will help me finish the puzzle. This PR contains my improvements.
Among other things, I renamed the source code directory to "Src". See the file Src/ChangeLog for a synopsis of my work. The updated README.md has detailed build and usage instructions. Also, I removed the xcode project files only because I don't use xcode and don't want anyone to mistakenly think that it should still build that way. I'm guessing is it wouldn't be difficult to recreate working versions of the xcode project anyway.
Ken