Repository navigation
Build: a .venv made by setup.bat no longer empties Buddy.exe of its libraries - #47
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buddy.spec kept every module under the repo folder out of Buddy.exe, so that Pips, KeyIt and the glue load from dist\Buddy\app. The .venv that setup.bat makes (and build.bat uses by default) is under the repo folder too, so a build from it left out numpy, pystray, pynput and 1,900 other library modules: Buddy.exe was 3.6 MB where 1.13.0 has 17.6 MB, with no build error.
Now only the repo's own sources are kept out; anything in a site-packages folder stays in.
Checked on Windows, built from a fresh worktree with its own .venv: before 311 modules in Buddy.exe, after 1,860 (1.13.0: 2,209, the difference is pygments, psutil, pytest and three cached comtypes modules from the earlier build computer, none of them in requirements.txt). None of the repo's own modules is frozen. The zip is 179.9 MB (1.13.0: 181.3 MB).