Repository navigation
feat(api)!: add missing actions before the beta - #76
Merged
Merged
Conversation
- mail() (Pixelletter) on offers, confirmations, credit notes, delivery notes, letters and reminders; InvoiceMailOptions is MailOptions (Rector renames it) - recurrings->stop() - recurrings->emailReceivers->update() with RecurringEmailReceiverUpdateOptions - contacts->avatar() and users->avatar()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second part of the API pass before 4.0.0-beta.1: the endpoint gaps that fit into existing classes.
Changes
mail()(Pixelletter) on offers, confirmations, credit notes, delivery notes, letters and reminders (spec: same fields as invoices).InvoiceMailOptionsis renamed toMailOptions; the Rector upgrade set renames it, with a fixture.recurrings->stop()(PUT /recurrings/{id}/stop). Verified against the sandbox:nextCreationDatebecomesnull. The earlier "Content-Type header missing" 400 does not happen, sinceputVoid()always sends a JSON body.recurrings->emailReceivers->update()with the generatedRecurringEmailReceiverUpdateOptions(get()/getOrFail()already came from the base class).contacts->avatar(),users->avatar(), same asclients->avatar().Deferred to 4.1 (additive): write access for units, roles, free texts, email templates, reminder texts and country taxes; incoming items and
incomings->pdf();clients/{id}/customfield,invoices/preset,countries/currencies->get().Test plan
composer test(3,697), PHPStan, lint, Rector dry-run,generate:check, Infection on changed lines (100 %), docs buildcanStopRecurringInSandbox(new), email receiver update, contact avatar, user avatar