Open
Conversation
Change `mainFrame` and `eastPanel` from `JPanel` to `JSplitPane`. This allows the users to resize different views as they want.
This updates the row count based on height when the component is resized.
Lenart12
added a commit
to Lenart12/SicTools
that referenced
this pull request
Nov 7, 2022
This commit assumes that `tabDis` rows can be resized and adds guards to prevent UB when updating the view with arbitrary row count. This is done in prepration for PR jurem#35
Lenart12
added a commit
to Lenart12/SicTools
that referenced
this pull request
Nov 7, 2022
This commit assumes that `tabDis` rows can be resized and adds guards to prevent UB when updating the view with arbitrary row count. This is done in prepration for PR jurem#35
jurem
pushed a commit
that referenced
this pull request
Nov 9, 2022
* Make `DisassemblyView` scrollable This commit adds scroll wheel listener to `DissasemblyView` which moves the view up or down. * Make `MemoryView` scrollable This commit adds scroll wheel listener to `MemoryView` which moves the view up or down. * Scroll `DissasemblyView` with PC while executing code This moves the `DissasemblyView` with the PC instead of resetting the view with PC on top. * Make `updateDis` calculations row resizing aware This commit assumes that `tabDis` rows can be resized and adds guards to prevent UB when updating the view with arbitrary row count. This is done in prepration for PR #35 * Fix bug scrolling with touchpad in `MemoryView`
Contributor
Author
|
Ready to merge |
Collaborator
|
There appears to be a (possibly preexisting) issue with the CPU view when resizing:
The actual contents should fit normally, and by increasing the size just a bit everything looks OK again. I’ll try to reproduce on another system, but maybe you could take a look. Other than that the change looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
mainFrameandeastPanelfromJPaneltoJSplitPane.This allows the users to resize different views as they want.