Skip to content

Add test case for nullSafeToString with Double array#5724

Closed
skonda33 wants to merge 3 commits into
junit-team:mainfrom
skonda33:siva1
Closed

Add test case for nullSafeToString with Double array#5724
skonda33 wants to merge 3 commits into
junit-team:mainfrom
skonda33:siva1

Conversation

@skonda33
Copy link
Copy Markdown
Contributor

@skonda33 skonda33 commented Jun 2, 2026

Add test case for nullSafeToString with Double array

I hereby agree to the terms of the JUnit Contributor License Agreement.


Definition of Done

skonda33 added 3 commits June 2, 2026 15:39
Signed-off-by: siva kumar konda <skonda3@gmail.com>
This reverts commit 3500c83.

Signed-off-by: siva kumar konda <skonda3@gmail.com>
Signed-off-by: siva kumar konda <skonda3@gmail.com>
@sbrannen
Copy link
Copy Markdown
Member

sbrannen commented Jun 3, 2026

Hi @skonda33,

Thanks for the PR.

Unfortunately, I don't think this adds much benefit.

The nullSafeToStringChecks() test method is not intended to cover an exhaustive set of use cases. Rather, it's only intended to check a minimal subset of use cases.

For example, the assertion for nullSafeToString(new Integer[] { 34, 42 }) is there to ensure that a one-dimensional array for a wrapper (Integer, Double, Float, etc.) is supported.

In light of that, I don't think we need an additional assertion for a Double array, and I'm closing this PR.

In the future, I suggest that you ask the team if certain kinds of tests or assertions are desired before spending time on creating and submitting a PR. For example, you could create an issue to discuss your proposal or start a discussion.

Cheers,

Sam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants