Add test case for defaultToString() in StringUtils#5723
Open
skonda33 wants to merge 19 commits into
Open
Conversation
sbrannen
requested changes
Jun 3, 2026
| @Test | ||
| void defaultToStringChecks(){ | ||
| assertEquals("null",defaultToString(null)); | ||
| } |
Member
There was a problem hiding this comment.
It doesn't make sense to call this method "...Checks" if there is only a single check/assertion.
To remedy that, you could introduce an additional assertion analogous to the startsWith() check in nullSafeToStringForObjectWhoseToStringImplementationThrowsAnException().
In addition, the code is missing a space after the comma (",").
Did you run a full local build before submitting the PR?
sbrannen
added
type: task
component: Jupiter
component: Platform
status: waiting-for-feedback
and removed
component: Jupiter
labels
sbrannen
changed the title
defaultToString() in StringUtils
…-team#5701) Same as b5f1766, but for the `InterceptingExecutableInvoker` specifically. An interesting aspect of this API was that we open taken in nullable values, wrap them in an `Optional`, pass them down the call chain and then unwrap them later on. With JSpecify available this isn't necessary at all and we can also remove this behavior. Signed-off-by: siva kumar konda <skonda3@gmail.com>
…3.5.6 (junit-team#5704) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: siva kumar konda <skonda3@gmail.com>
…3.5.6 (junit-team#5705) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: siva kumar konda <skonda3@gmail.com>
Signed-off-by: siva kumar konda <skonda3@gmail.com>
This reverts commit 3500c83. Signed-off-by: siva kumar konda <skonda3@gmail.com>
Signed-off-by: siva kumar konda <skonda3@gmail.com>
Signed-off-by: siva kumar konda <skonda3@gmail.com>
This reverts commit 3500c83. Signed-off-by: siva kumar konda <skonda3@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: siva kumar konda <skonda3@gmail.com>
…am#5707) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: siva kumar konda <skonda3@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: siva kumar konda <skonda3@gmail.com>
…#5712) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: siva kumar konda <skonda3@gmail.com>
…eam#5715) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: siva kumar konda <skonda3@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: siva kumar konda <skonda3@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: siva kumar konda <skonda3@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: siva kumar konda <skonda3@gmail.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Signed-off-by: siva kumar konda <skonda3@gmail.com>
…import statement Signed-off-by: siva kumar konda <skonda3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test case for defaultToString method
I hereby agree to the terms of the JUnit Contributor License Agreement.
Definition of Done
@APIannotations