-
Notifications
You must be signed in to change notification settings - Fork 38
JEP-0013 Phase 3 - operator image #1061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
a2d7498
2423e94
435eebe
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -312,6 +312,10 @@ type TelemetryConfig struct { | |
| // gRPC configuration for the telemetry service. | ||
| // Use this to configure TLS when not using cert-manager. | ||
| GRPC TelemetryGRPCConfig `json:"grpc,omitempty"` | ||
|
|
||
| // Metrics configures reverse-scrape fan-out and Prometheus exposition | ||
| // (JEP-0013). Loki and ServiceMonitor fields are later phases. | ||
| Metrics TelemetryMetricsConfig `json:"metrics,omitempty"` | ||
| } | ||
|
|
||
| // TelemetryGRPCConfig defines gRPC configuration for the telemetry service. | ||
|
|
@@ -325,6 +329,22 @@ type TelemetryGRPCConfig struct { | |
| TLS TLSConfig `json:"tls,omitempty"` | ||
| } | ||
|
|
||
| // TelemetryMetricsConfig configures telemetry /metrics reverse-scrape behavior. | ||
| type TelemetryMetricsConfig struct { | ||
| // Allowlist of keys to include in Prometheus exemplars. Unlisted keys are omitted. | ||
| // +kubebuilder:default={"client","lease_id"} | ||
| ExemplarKeys []string `json:"exemplarKeys,omitempty"` | ||
|
|
||
| // Allowed driver_type label values. Unlisted types are remapped to "other". | ||
| // +kubebuilder:default={"power","storage","network","serial","console","video","composite"} | ||
| DriverTypeEnum []string `json:"driverTypeEnum,omitempty"` | ||
|
|
||
| // Max wait for parallel exporter MetricsStream responses during a /metrics fan-out. | ||
| // Should be lower than the Prometheus scrape_timeout. | ||
| // +kubebuilder:default="7s" | ||
| ScrapeTimeout *metav1.Duration `json:"scrapeTimeout,omitempty"` | ||
|
Comment on lines
+342
to
+345
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also set an upper limit to avoid keeping connections open for very long times.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 2 minutes max? (and sounds excessive) |
||
| } | ||
|
|
||
| // TelemetryLoggingConfig configures the log push path to the telemetry service. | ||
| type TelemetryLoggingConfig struct { | ||
| // Filter controls which log entries are forwarded to the telemetry service. | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A user with CR write access can set either list to an arbitrarily large array for
ExemplarKeys []stringandDriverTypeEnum []string. Adding// +kubebuilder:validation:MaxItems=<insert a good limit here>and// +kubebuilder:validation:MaxLength=<insert a good limit here>per item would enforce a bound.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be worth limiting to 16 for example? /8 default + 8 custom, more than enough.