Skip to content

fix: add scope (public/private) selection when saving SQL #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lettimepassby wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: add scope (public/private) selection when saving SQL #171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions frontend/src/components/Main/Explore/QueryConsole/SaveSnippetDialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,17 @@
:title="$tc('SaveSQL')"
:visible.sync="iVisible"
:modal="false"
:append-to-body="true"
width="40%"
>
<el-form ref="form" :model="form" label-width="80px">
<el-form-item :label="$tc('Name')">
<el-input v-model="form.name" />
</el-form-item>
<el-form-item :label="$tc('Scope')">
<el-radio v-model="form.scope" label="private">{{ $tc('Private') }}</el-radio>
<el-radio v-model="form.scope" label="public">{{ $tc('Public') }}</el-radio>
</el-form-item>
</el-form>

<span slot="footer" class="dialog-footer">
Expand Down Expand Up @@ -39,7 +44,8 @@ export default {
data() {
return {
form: {
name: ''
name: '',
scope: 'private'
}
}
},
Expand Down Expand Up @@ -69,7 +75,8 @@ export default {
axios.post('/api/v1/ops/adhocs/', {
name: this.form.name,
args: this.content,
module: store.getters.profile?.dbType
module: store.getters.profile?.dbType,
scope: this.form.scope
}, {
headers: {
'X-CSRFToken': csrfToken
Expand Down
4 changes: 3 additions & 1 deletion frontend/src/i18n/langs/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
"notAlphanumericUnderscore": "Only alphanumeric characters and underscores are allowed.",
"notParenthesis": "Parentheses are not allowed.",
"InvalidJson": "Invalid JSON format.",
"requiredHasUserNameMapped": "Username attr is required."
"requiredHasUserNameMapped": "Username attr is required.",
"Public": "Public",
"Private": "Private"
}

4 changes: 3 additions & 1 deletion frontend/src/i18n/langs/ja.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,7 @@
"notAlphanumericUnderscore": "仅支持字母、数字和下划线。",
"notParenthesis": "不能包含括号。",
"InvalidJson": "JSON 格式错误.",
"requiredHasUserNameMapped": "用户名属性是必需的。"
"requiredHasUserNameMapped": "用户名属性是必需的。",
"Public": "公開",
"Private": "非公開"
}
4 changes: 3 additions & 1 deletion frontend/src/i18n/langs/zh.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,7 @@
"notAlphanumericUnderscore": "仅支持字母、数字和下划线。",
"notParenthesis": "不能包含括号。",
"InvalidJson": "JSON 格式错误.",
"requiredHasUserNameMapped": "用户名属性是必需的。"
"requiredHasUserNameMapped": "用户名属性是必需的。",
"Public": "公有",
"Private": "私有"
}
4 changes: 3 additions & 1 deletion frontend/src/i18n/langs/zh_Hant.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,7 @@
"notAlphanumericUnderscore": "仅支持字母、数字和下划线。",
"notParenthesis": "不能包含括号。",
"InvalidJson": "JSON 格式错误.",
"requiredHasUserNameMapped": "用户名属性是必需的。"
"requiredHasUserNameMapped": "用户名属性是必需的。",
"Public": "公有",
"Private": "私有"
}