Clean up CLI package#44
Merged
Merged
Conversation
cli.ts was a simpler duplicate of index.ts that nothing imported or referenced in bin/exports. Removes the file and the 6 associated build scripts (build:no-prompt:esm/cjs, data, data:abs, data:rec, options). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Replaces 12 per-file build scripts with a single --bundle entry point build for each format (ESM and CJS). esbuild resolves the module graph from index.ts, so individual file builds are unnecessary. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- Remove unused `fuzzy` and `inquirer` dependencies (only `@inquirer/prompts` is used) - Change `@jspsych/metadata` dependency to `*` so npm resolves the local workspace package - Remove unused `saveTextToFile` export from data.ts - Add TypeScript types to all untyped function parameters - Remove `.js` extensions from local imports Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cli.tsentry point (duplicate ofindex.ts, not referenced inbinorexports)fuzzyandinquirerdependencies*version for@jspsych/metadataso npm resolves the local workspace package instead of pulling from the registrydata.tsandindex.ts.jsextensions from local imports (aligns with ES2020 module resolution used in the metadata package)saveTextToFileexportTest plan
npm run buildpasses inpackages/clinpm run buildpasses at root (all packages)@jspsych/metadataresolves as workspace symlinkjspsych-metadata-cliinteractive flow🤖 Generated with Claude Code