Fix broken test suite#42
Merged
Merged
Conversation
The test suite was completely broken because @jspsych/config was missing as a dependency, and the project used NodeNext module resolution which is incompatible with @jspsych/config's Sucrase-based Jest transform. - Add @jspsych/config as a devDependency - Switch tsconfig from NodeNext to ES2020 module resolution to align with the rest of the jsPsych ecosystem - Remove .js extensions from source and test imports - Add root jest.config.cjs using Jest projects to discover package tests All 19 tests now pass. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
- Add .github/workflows/ci.yml that runs build and test on all PRs and pushes to main - Replace the "# add tests back in here" comment in release.yml with an actual test step Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@jspsych/configdependency and NodeNext module resolution incompatibility with the shared Jest config@jspsych/configas a devDependency and switched from NodeNext to ES2020 module resolution to align with the rest of the jsPsych ecosystemjest.config.cjsthat uses Jest projects to discover package-level test configsAll 19 existing tests now pass.
Test plan
npm testruns and all 19 tests passnpm run buildstill succeeds🤖 Generated with Claude Code