Conversation
…rsion of validator
… out errors behind validate
🦋 Changeset detectedLatest commit: 91e8139 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implementation calls the Psych-DS validator and prints out a summary of the validation results. This is called when the user passes in existing metadata and on the completion of the process when the final metadata and data files are written. The summary of the printed results is the number of errors or warnings. The errors are always shown whereas the warnings are only displayed when called with the "--verbose" flag.
The guiding and prompting process and specifically how we should prompt the user to deal with these warnings and errors needs to be more fully fleshed out. This is will need to be coordinated with the Psych-DS team because there are areas where I am not entirely clear. This will be a continued process and this version is still the initial version.
Lingering issues are the problem of ".json" files being not allowed and the naming of data files. I am leaning towards renaming data files when rewriting them when copying them in the validator to leave the issue of how to rename data files post-trial is a more significant JsPsych architecture related issue.