Skip to content
This repository was archived by the owner on Feb 18, 2024. It is now read-only.

fix for bootstrap@4.0.0-beta#1056

Open
ghost wants to merge 1 commit intomasterfrom
unknown repository
Open

fix for bootstrap@4.0.0-beta#1056
ghost wants to merge 1 commit intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Aug 15, 2017

added overrides for bootstrap@4.0.0-beta.
added popper.js to registry.

added popper.js to registry.
Copy link
Copy Markdown
Collaborator

@aluanhaddad aluanhaddad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greetings. Thank you for the PR!

Unfortunately, it appears that bootstrap expects Popper to be available as a global. It throws a very specific error if that is not the case.

This means there will need to be an override for popper as well.
The following should work:
package-overrides/npm/popper.js@1.0.0.json

{
  "main": "dist/umd/popper",
  "shim": {
    "dist/umd/popper": {
      "exports": [
        "Popper"
      ]
    }
  }
}

"dist/js/npm"
],
"directories": {
"lib": "dist"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In previous overrides for bootstrap the SASS files were included, for those who work directly with the source, for example by overriding bootstrap mixins.

To preserve this use case it would be best to remove the "directories" property and instead qualify "main" with dist/.

@aluanhaddad
Copy link
Copy Markdown
Collaborator

It looks like the next beta release will include Popper.js in the bundle itself which will make this easier.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant