Skip to content

🎨 Palette: Add focus-visible offset styles to BookDetailsPanel buttons - #125

Open
jspann21 wants to merge 1 commit into
mainfrom
palette-focus-ring-accessibility-17735496807206389785
Open

jspann21 wants to merge 1 commit into
mainfrom
palette-focus-ring-accessibility-17735496807206389785

Conversation

@jspann21

Copy link
Copy Markdown
Owner

🎨 Palette: Add focus-visible offset styles to BookDetailsPanel buttons

💡 What: Added standard focus-visible:ring-offset-2, focus-visible:ring-offset-white, and dark:focus-visible:ring-offset-slate-900 classes to the shared button variables in BookDetailsPanel.tsx. Cleaned up duplicate focus classes on inline action buttons (Save, Rescan, Open, Hide, Delete, Undo).
🎯 Why: Without these offset classes, keyboard navigation focus rings lack contrast against the panel background, making it difficult for keyboard users to see which element is focused. Consolidating the focus styling in the shared constants prevents visual drift.
📸 Before/After: Verified via headless screenshot generation during task execution.
♿ Accessibility: Improves keyboard navigation visibility (WCAG Focus Visible compliance) in the book details drawer.


PR created automatically by Jules for task 17735496807206389785 started by @jspann21

💡 What: Added standard `focus-visible:ring-offset-2`, `focus-visible:ring-offset-white`, and `dark:focus-visible:ring-offset-slate-900` classes to the shared button variables in `BookDetailsPanel.tsx`. Cleaned up duplicate focus classes on inline action buttons (Save, Rescan, Open, Hide, Delete, Undo).
🎯 Why: Without these offset classes, keyboard navigation focus rings lack contrast against the panel background, making it difficult for keyboard users to see which element is focused. Consolidating the focus styling in the shared constants prevents visual drift.
📸 Before/After: Verified via headless screenshot generation during task execution.
♿ Accessibility: Improves keyboard navigation visibility (WCAG Focus Visible compliance) in the book details drawer.

Co-authored-by: jspann21 <179991454+jspann21@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant