Skip to content

🎨 Palette: Enable native Enter-to-submit for cover URL input - #124

Open
jspann21 wants to merge 1 commit into
mainfrom
palette/form-enter-to-submit-11805158047522853008
Open

jspann21 wants to merge 1 commit into
mainfrom
palette/form-enter-to-submit-11805158047522853008

Conversation

@jspann21

Copy link
Copy Markdown
Owner

💡 What: Wrapped the custom URL input and "Add" button in CoverPickerModal.tsx in a <form> element, changed the button type to "submit", and handled submission via the form's onSubmit event instead of an onKeyDown listener on the input.

🎯 Why: Previously, the user had to explicitly press "Enter" while focused strictly on the input, or click the button. Using a <form> provides native web behavior, meaning the user can submit the input naturally across all devices and assistive technologies, making the component feel more native and intuitive.

📸 Before/After: No visible changes, but the underlying DOM now correctly uses a <form> tag.

Accessibility: Native HTML forms automatically trigger submit on the Enter key regardless of which element inside the form has focus, and provide better hooks for screen readers to announce form submission.


PR created automatically by Jules for task 11805158047522853008 started by @jspann21

Co-authored-by: jspann21 <179991454+jspann21@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant