Refactor multisource plugin to use directive framework#6
Merged
Conversation
Align the Go implementation with the TypeScript version by using the directive package instead of manually implementing token registration, custom matchers, and rule modifications. Add jsonic/path/go as a test dependency for Path plugin compatibility testing. https://claude.ai/code/session_01UCcfE3sNcpkMr5eYdoR12u
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored the multisource plugin to leverage the new directive framework instead of implementing custom lexer matchers and token handling. This simplifies the codebase and improves maintainability by delegating parsing logic to the directive system.
Key Changes
lexModestate machine, custom token matchers (msrcpath), and manual path parsing logic that handled quoted and unquoted pathsDirectiveOptionsconfiguration that defines the multisource directive behavior declarativelyresolveSource()into a standalone function that's called from the directive's action handlerCustomcallback to handle special cases like top-level references and map merging@pathsyntax, and top-level reference resolutionImplementation Details
@pathappears in pair position) is now handled through parent rule inspection in the action handler@pathreferences uses rule depth and custom flags to distinguish between value and map contextsCustomcallback modifies theval,map, andpairrules to inject directive-specific alternatives at appropriate positionshttps://claude.ai/code/session_01UCcfE3sNcpkMr5eYdoR12u