Conversation
…entation The previous implementation bypassed jsonic's grammar system entirely, using a standalone parser. This rewrite mirrors the TypeScript CSV plugin architecture with proper jsonic grammar rules (csv, newline, record, list, elem, val, text) and a custom CSV string matcher for RFC 4180 double-quote escaping. Key changes: - csv.go: Options and types only (removed standalone parser) - plugin.go: Full grammar-based implementation using jsonic Rule/AltSpec - Custom #RL/#RS token types to work around jsonic's global IGNORE set - Single-newline lexing for proper empty record handling - Comment starter cleanup when comments are disabled https://claude.ai/code/session_01Ehie1ims4jJtda9A6MmD1x
The trim.json fixture had unresolved git merge conflict markers from the merge of main, causing the TS fixtures test to fail with a JSON parse error. https://claude.ai/code/session_01Ehie1ims4jJtda9A6MmD1x
On Windows, git's core.autocrlf converts \n to \r\n on checkout, which breaks CSV fixture tests that depend on specific line endings inside quoted fields (e.g. papa-quoted-field-with-line-break). Mark fixture files as binary to prevent line ending conversion. https://claude.ai/code/session_01Ehie1ims4jJtda9A6MmD1x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…entation
The previous implementation bypassed jsonic's grammar system entirely, using a standalone parser. This rewrite mirrors the TypeScript CSV plugin architecture with proper jsonic grammar rules (csv, newline, record, list, elem, val, text) and a custom CSV string matcher for RFC 4180 double-quote escaping.
Key changes:
https://claude.ai/code/session_01Ehie1ims4jJtda9A6MmD1x