fix: restore sibling errors on union branch success (Python, PHP)#161
Merged
Conversation
InstanceValidator union-type branch wiped accumulated sibling errors when a union member validated successfully. The code broke out of the loop without restoring self.errors/this->errors from backup, leaving the error list empty and discarding all previously collected violations. Always capture branch errors in a local variable and restore the backup before checking success, both on the match and non-match paths. Fixes #160
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #160 —
InstanceValidatorunion-type branch wiped accumulated sibling errors when a union member validated successfully.Root Cause
In both the Python and PHP implementations, the union validation loop set
self.errors = []before trying each branch type. On a successful branch match, the code broke out of the loop without restoring the backup, leaving the error list empty and discarding all previously collected violations for sibling properties.Fix
Always capture branch errors in a local variable and restore the backup before checking success — both on match and non-match paths. This ensures sibling errors are preserved regardless of union validation outcome.
Other SDKs
Checked all 11 SDK implementations:
Tests
Added regression tests in both Python and PHP covering the exact reproducer from the issue (object with failing
int64siblings + succeeding["double", "null"]union property).