Stop mixing Rake::DSL into Object; use Rake::Task.define_task

[zev]

Fixes #1.

Rake no longer defines its DSL at the top level outside a Rakefile. This gem worked around that with a global include Rake::DSL, which leaks task, file, sh, etc. into every object, the thing modern Rake removed on purpose.

• ant_import and ant_task now call Rake::Task.define_task instead of the bare task.
• Removed require 'rake/dsl_definition' and the global include Rake::DSL.
• test_rake.rb no longer includes Rake::DSL.

ant, ant_import and ant_task remain top-level methods, so Rakefiles are unaffected. Scripts that relied on this gem leaking task/sh into the top level will need include Rake::DSL themselves, so this probably deserves a minor version bump.

Tested on JRuby with Ant 1.10.18: 30 runs, 0 failures (1 skip: ANT_HOME unset). Also ran a real Rakefile using ant_import and ant_task, and confirmed Object.new.respond_to?(:task, true) is false after require 'ant'.

Stacked on #7: this branch includes #7's commit (its head is in a fork, so it can't be the PR base). Once #7 merges, that commit drops out of this diff. ant_graph_task now also uses Rake::Task.define_task and test_graph.rb no longer includes Rake::DSL, so no follow-up is needed. Full suite with both: 33 runs, 0 failures (1 skip: ANT_HOME unset).

🤖 Generated with Claude Code

[zev]

Upgrade notes for existing users

Who is affected: only code that is not a Rakefile but relied on require 'ant' (or rake/ant) making Rake's DSL methods available everywhere. Previous versions did a global include Rake::DSL, which put task, file, directory, namespace, rule, desc, sh, multitask, etc. on every object. That include is gone.

Not affected: Rakefiles. Rake already provides its DSL to a Rakefile's main, and ant, ant_import, ant_task (and ant_graph_task from #7) are still top-level methods that work as before:

# Rakefile: no changes needed
require 'ant'
ant_import
ant_task :compile => :prep do
  javac :srcdir => 'src', :destdir => 'build'
end

Symptom if you are affected: NoMethodError: undefined method 'task' for main:Object (or file, sh, namespace, ...) after upgrading. This occurs in plain Ruby scripts, library code, classes or tests that call those methods directly after requiring this gem.

How to fix it (any one of these):

# 1. Opt in to the DSL where you use it (what this gem used to do globally)
require 'ant'
include Rake::DSL        # at top level of a script
# or inside a class/module:
class MyBuild
  include Rake::DSL
end

# 2. Extend a single object instead of polluting everything
builder = Object.new.extend(Rake::DSL)

# 3. Skip the DSL and call Rake's API directly
Rake::Task.define_task(:compile => :prep) { ... }
Rake::FileTask.define_task('out.jar' => 'src') { ... }

Option 1 is the minimal change for an existing script. Options 2 and 3 are preferred for new code because they do not leak methods into every object, which is what current Rake itself avoids.

Because this is a behaviour change for non-Rakefile users, I'd suggest a minor version bump and a changelog line when releasing.

[zev]

@headius let me know if there is anything more here.