Let amend mode load previous commit message even if the editor's working dir is outside the repo#201
Open
bonderado wants to merge 1 commit intojreybert:masterfrom
Open
Let amend mode load previous commit message even if the editor's working dir is outside the repo#201bonderado wants to merge 1 commit intojreybert:masterfrom
bonderado wants to merge 1 commit intojreybert:masterfrom
Conversation
bonderado
force-pushed
the
amendFromAbove
branch
from
add2096 to
34af21d
Compare
The path to the ".git" directory returned by git rev-parse --git-dir and stored in "b:magit_git_dir", can be a relative one, which would not work for opening file "COMMIT_EDITMSG" when the currently edited file was opened from outside the repository, so we make "b:magit_git_dir" absolute via "git rev-parse --absolute-git-dir". Thanks to user v-slava for suggesting the use of --absolute-git-dir.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I often work with repositories that depend on each other, but are meant to reside in sibling directories (I cannot change this structure).
To make grepping all the repositories at once, I usually start neovim from the common parent directory, but then trying to amend a commit with CA, fails to load the previous message as described in #200.
This pull request tries to address this by invoking fnamemodify(git_dir, ':p') on the path returned by the previous call to
git rev-parse --git-dir
making it absolute.
In my tests this approach works when opening the file from: