Repository navigation
Fix project-scoped secrets being unretrievable via Get-StrongboxSecret - #34
Merged
Merged
Conversation
Resolve-StrongboxSecretTarget only treated a name as project-scoped if a matching entry existed in the cloud-sync manifest, but nothing on Set-StrongboxSecret's normal write path populates that manifest -- it's sync-only bookkeeping. A secret written with Set-StrongboxSecret -Scope Project was stored under Name::Project but could never be found by Get-StrongboxSecret, which always fell back to the global name instead. Resolve project scope by probing the vault directly (Get-SecretInfo, no decryption) for the project-scoped internal name instead, so it works immediately after a plain local Set-StrongboxSecret call, with no dependency on whether the secret has ever been synced. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TNz4QZBeWEPxt4u4rVyVUy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve-StrongboxSecretTargetonly treated a name as project-scoped if a matching entry existed in the cloud-sync manifest, but nothing onSet-StrongboxSecret's normal write path populates that manifest — it's sync-only bookkeeping (seePush-StrongboxSecret/Pull-StrongboxSecret/Get-StrongboxSyncStatus).Set-StrongboxSecret -Scope Projectwas stored underName::Project, butGet-StrongboxSecretcould never find it and always silently fell back to the global name instead — a project-scoped secret was effectively write-only.Get-SecretInfo, no decryption) for the project-scoped internal name, instead of depending on the sync manifest. Works immediately after a plain localSet-StrongboxSecretcall, with no dependency on whether the secret has ever been synced.Test plan
Set-StrongboxSecret -Name X -Value Y -Scope Project(letting-Projectauto-infer from the git remote, matching howGet-StrongboxSecretresolves it) followed byGet-StrongboxSecret -Name X— confirmed returnsY(previously failed with "missing or unreadable secret")Install-StrongboxModule.ps1and re-ran the round trip against the live installed copyFound and fixed while provisioning real project-scoped secrets (a Kraken API key/secret and a Hummingbot config password) for another project.
🤖 Generated with Claude Code
https://claude.ai/code/session_01TNz4QZBeWEPxt4u4rVyVUy