Repository navigation
Scope stdout-safe warning suppression to non-interactive sessions only - #21
Merged
Merged
Conversation
Follow-up to #20: that fix set \$WarningPreference = 'SilentlyContinue' for every invocation, which also silences legitimate warnings for a human typing at a real terminal - the contamination bug it fixes only manifests when stdout is redirected (SSH, a shell script), not interactively. Moved Test-InteractiveTerminal earlier in the file (was only defined later, for Assert-RevealAllowed) and gated the suppression on it, matching the same interactive/non-interactive distinction --real already draws. Also reworded the comment to state the current invariant instead of narrating the bug's history, per doc-comment discipline. Verified: 43/43 Pester tests pass; confirmed on the Pi that `strongbox get POSTGRES_USER --real` still returns clean bytes non-interactively. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WGra6GqN8qAxEDHbhmJwP2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #20 (code-review findings after that PR was already merged).
Summary
Test plan
🤖 Generated with Claude Code
https://claude.ai/code/session_01WGra6GqN8qAxEDHbhmJwP2