make time cache key less likely to collide with real keys - #45
Merged
Conversation
I noticed that you can break the swr behaviour by using a key ending in `_time`.
Example:
```js
const swr = createStaleWhileRevalidateCache({
minTimeToStale: 5000,
storage,
})
const getRandom = async () => {
await new Promise(resolve => setTimeout(resolve, 20))
return Math.random()
}
const log = ({value, ...rest}) => {
console.log(value, JSON.stringify(rest))
}
let start = Date.now()
const b4 = () => console.log(`Starting after ${(Date.now() - start) / 1000}s`)
b4()
await swr('test', getRandom).then(log)
await swr('test_time', getRandom).then(log)
await swr('test', getRandom).then(log)
await new Promise(resolve => setTimeout(resolve, 1000))
await swr('test', getRandom).then(log)
```
Owner
|
Thanks, this looks like a more sensible SWR cache key suffix. If you fix the Prettier formatting issue, I'd be happy to merge this in (assuming the build passes after that). |
Contributor
Author
|
Did the fix by hand 😬 Looks green now. Thanks for the great lib btw! |
Owner
|
Thanks for your fix! I'm glad you're getting some value from the lib. |
Owner
|
Now available as v3.4.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that you can break the swr behaviour by using a key ending in
_time.Example:
This just makes this less likely to happen by mistake