Repository navigation
fix(ui): tiles in a row share one height, and never get too narrow - #450
Merged
Merged
Conversation
Since tile text wraps instead of being cut off (#447), a tile with a longer label or value grew taller than its neighbours. The grid did stretch each row, but on the dashboard and statistics the grid item is a wrapper (the info button's, or the edit mode slot), and the card inside never filled it. The height is now passed down through those wrappers, so every tile in a row is the same height, in edit mode too. The fixed column counts (4, 6, 8 and 12 beside the sidebar, 3 on tablets) made tiles as narrow as 173px, where readings such as "71% · Active" broke over two lines and made their whole row taller. The grid now fits as many tiles as it can at 13rem or wider, so from 700px up every row is a single 58px line. Phones keep two columns. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since tile text wraps instead of being cut off (#447), the dashboard tiles no longer lined up: a tile with a longer label or value grew taller than the others in its row.
Same height per row
The grid already stretched each row to its tallest tile. But on the dashboard and statistics, each tile sits inside a wrapper (for the info button, and in edit mode the draggable slot), and the card inside never filled it. The height is now passed down through those wrappers, so every tile in a row has the same height, in edit mode too.
Tiles never get too narrow
The fixed column counts (4, 6, 8 and 12 beside the sidebar, 3 on tablets) made tiles as narrow as 173px. At that width, values like "71% · Active" and "Off · 21.0 °C" broke over two lines and made their whole row taller. The grid now fits as many tiles as it can at 13rem or wider:
Phones keep two columns. The 1440/1920/2500 breakpoints for the grid are gone.
Test plan
pnpm exec vitest run(860 tests) and stylelint pass.🤖 Generated with Claude Code