Skip to content

Fix CI release notes and package assets - #53

Merged
joshrmcdaniel merged 2 commits into
developfrom
fix/ci-notes
Oct 2, 2026
Merged

joshrmcdaniel merged 2 commits into
developfrom
fix/ci-notes

Conversation

@joshrmcdaniel

@joshrmcdaniel joshrmcdaniel commented Oct 2, 2026 •

Copy link
Copy Markdown
Owner

The tag-triggered CI job creates GitHub releases, but it currently ignores the curated RELEASE.md and can upload old DEB/RPM packages left in cached target/ directories. Check out the tagged source and pass RELEASE.md to softprops/action-gh-release; clear Privaxy's cached packages before packaging on native and MIPS targets, and restrict RPM uploads to privaxy-*.rpm.

The existing flow remains develop → main, followed by pushing a version tag on the merged commit. The workflow's triggers, build dependencies, package/image publishing, and permissions are unchanged.

Validation: workflow YAML parses, the checkout precedes release creation, the configured notes file exists, and git diff --check passes. A temporary package-output fixture verifies both cleanup steps remove older Privaxy packages while preserving the binary and unrelated files. The body_path input is supported by the action's upstream documentation.

@zeropath-ai

zeropath-ai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

✅ No security or compliance issues detected. Reviewed everything up to 1e73042.

Security Overview
Detected Code Changes
Change Type Relevant files
Enhancement ► .github/workflows/ci.yml
    Discard previous build artifacts before packaging; adjust RPM path expectations
► .github/workflows/ci.yml
    Checkout release notes step added
► .github/workflows/ci.yml
    Pass release notes file to release action (RELEASE.md) and enable generation of release notes
Bug Fix ► .github/workflows/ci.yml
    Correct RPM artifact path patterns to include privaxy-*.rpm instead of *.rpm

@joshrmcdaniel joshrmcdaniel changed the title Use RELEASE.md in CI releases Fix CI release notes and package assets Oct 2, 2026
@joshrmcdaniel
joshrmcdaniel merged commit 34c37ef into develop Oct 2, 2026
3 checks passed
@joshrmcdaniel
joshrmcdaniel deleted the fix/ci-notes branch October 2, 2026 13:24
joshrmcdaniel added a commit that referenced this pull request Oct 2, 2026
* fix: include curated CI release notes

* fix: exclude stale packages from release assets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant