Fix MysqliStatement to work with named params#351
Merged
richard67 merged 2 commits intojoomla-framework:3.x-devfrom Oct 26, 2025
Merged
Conversation
Contributor
|
Thanks, I think nobody noticed this because no one is using the statement class directly and the database driver doesn't accept any variables on |
HLeithner
approved these changes
Oct 18, 2025
Contributor
|
I've successfully tested this PR by creating the table and running the code added by this PR here to the unit test. Without this PR you get an error "Cannot access offset of type array on array", with line 309 of the With this PR the record is inserted without any error. |
Contributor
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that some time ago the named parameter feature was adjusted to cover for multiple keys. This place was missed and has been broken ever since.
@HLeithner This also covers the changes in #350. Both tests should still work after the references are removed.