#56 - DinersClub validation#58
Closed
frappacchio wants to merge 1 commit into
Closed
Conversation
Collaborator
ddayguerrero
left a comment
ddayguerrero
left a comment
There was a problem hiding this comment.
According to CONTRIBUTING.md:
Make sure to send pull requests to
develop
Sorry again 🙁 we're almost there! Fork from develop and point your changes to that branch!
jondavidjohn:develop from frappacchio:develop
The rest looks good, I can create a new payform release with the other pending changes as soon this is done!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @ddayguerrero
i've made new pull request as per your request :)
Let me know if everything it's ok now.
Refers to pull request #57
Thanks,
Francesco