Potential Vulnerability in Cloned Code#75
Open
Mifacopy wants to merge 1 commit intojoncampbell123:masterfrom
Open
Potential Vulnerability in Cloned Code#75Mifacopy wants to merge 1 commit intojoncampbell123:masterfrom
Mifacopy wants to merge 1 commit intojoncampbell123:masterfrom
Conversation
…mbedded null bytes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a potential security vulnerability in cloned code that appears to have missed an upstream security patch.
Details
ext/libmspack/mspack/chmd.cWhat this PR does
Applies the upstream security fix logic to the cloned implementation in this repository to address improper handling of malformed file names when parsing CHM headers.
References
Please review and merge this PR to ensure your repository is protected against this potential vulnerability.
Thank you for your time!