Repository navigation
chore: bump function-sdk-rust to 0.3.0 - #62
Merged
Merged
Conversation
The SDK Args now carries --metrics-address (same name, env and :8080 default), so the runtime own flag definition is dropped - the flattened clap Args would otherwise collide - and serve_main reads it from the SDK args. The flag surface and behavior are unchanged: the runtime still serves its own /metrics (engine registry) through ops.rs; the SDK metrics module stays inert here since the runtime owns its transport.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps to function-sdk-rust 0.3.0, whose
Argsnow carries--metrics-address(crossplane/function-sdk-rust#10).What changed
function-sdk-rust = "0.3.0"incrates/functionand the engine dev-dependency; lockfile updated.--metrics-addressflag definition is dropped fromServeArgs: the flattened SDKArgsnow provides it with the identical name,METRICS_ADDRESSenv and:8080default, and clap would refuse the duplicate.serve_mainreadsargs.sdk.metrics_address.--helpverified), and the runtime still serves its own/metricsfrom the engine registry throughops.rs- the SDK's metrics module is inert here because the runtime owns its raw-codec transport and never calls the SDK'sserve.Testing
cargo test --workspacegreen (12 suites, guest builds skipped - no guest-facing change); clippy-D warningsandcargo fmt --checkclean.function --helpshows--metrics-addressexactly as before.