Fix wrong variable reports in it_is_asserted_by#3
Open
seikichi wants to merge 1 commit into
Open
Conversation
Consider the following test:
```ruby
context do
let(:blk) { [1, 2, 3] }
it_is_asserted_by { blk == %w(a b c) }
end
```
The above test outputs the following report (`blk` is wrong!):
```
Failure/Error: Unable to find matching line from backtrace
it_is_asserted_by { blk == %w(a b c) }
| |
| false
#<Proc:0x...>
```
This is because `RSpec::PowerAssert.evaluate_example` sends
wrong assertion proc `pr` to PowerAssert::Context.
The `PowerAssert::Context` calls
`@assertion_proc.binding.eval('local_variables')`
and uses the local variables to create reports.
Thus, `PowerAssert::Context` uses wrong local variables to create report.
This commit fixes the above problem by wrapping
the assertion proc `pr` in `blk` binding context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider the following test:
The above test outputs the following report (
blkis wrong!):This is because
RSpec::PowerAssert.evaluate_examplesendswrong assertion proc
prtoPowerAssert::Context.The
PowerAssert::Contextcalls@assertion_proc.binding.eval('local_variables')and uses the local variables to create reports.
Thus,
PowerAssert::Contextuses wrong local variables to create report.This commit fixes the above problem by wrapping
the assertion proc
prinblkbinding context.