Skip to content

If dpr initially unknown, update in subsequent page impression - #4

Open
seb303 wants to merge 2 commits into
johsin18:5.x-devfrom
seb303:5.x-dev
Open

If dpr initially unknown, update in subsequent page impression#4
seb303 wants to merge 2 commits into
johsin18:5.x-devfrom
seb303:5.x-dev

Conversation

@seb303

@seb303 seb303 commented Apr 7, 2024

Copy link
Copy Markdown

Fix to address the issue mentioned here:
#3

Have submitted a similar PR for the Matomo Core Resolution plugin.
matomo-org/matomo#22080

@johsin18

johsin18 commented May 1, 2024

Copy link
Copy Markdown
Owner

Hi seb303,
I support your PR. However, could you please make it more complete

  • adapt FAQ
  • add a test
  • add a changelog entry

@seb303

seb303 commented May 1, 2024

Copy link
Copy Markdown
Author

Hi johnsin18,
I've updated the FAQ. I don't feel confident to add a test though as I'm not familiar with the testing framework used. I'm more likely to break something than to make the code safer! Sorry.

@johsin18

johsin18 commented Jun 4, 2024

Copy link
Copy Markdown
Owner

Hi seb303,
I'm on it, have to get back into the whole topic. Please have a bit more patience.
johsin18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants