feat: configurable keybinding system with agent presets#56
Open
IShaalan wants to merge 15 commits intojohannesjo:mainfrom
Open
feat: configurable keybinding system with agent presets#56IShaalan wants to merge 15 commits intojohannesjo:mainfrom
IShaalan wants to merge 15 commits intojohannesjo:mainfrom
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add cmdOrCtrl to Modifiers interface and update all platform:both app-layer bindings to use cmdOrCtrl instead of meta, so shortcuts work on Linux (Ctrl) as well as macOS (Cmd). Add a test to enforce this constraint going forward. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ection Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…lback Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…rsistence Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace ~20 hardcoded registerShortcut() calls in App.tsx with a registry-driven approach. Add registerFromRegistry() to shortcuts.ts that reads KeyBinding objects and maps action strings to handlers. Shortcuts are now registered via a reactive createEffect that reads resolvedBindings(), enabling automatic re-registration when the user changes keybinding presets or overrides. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Replace hardcoded if/else key handler in TerminalView with a registry-driven loop over terminal-layer bindings from resolvedBindings(). Adds Cmd+Backspace → \x15 (kill-line) as a new behavior from the defaults. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…flict detection Rewrite HelpDialog from a static shortcut cheat sheet into a full keybinding editor with preset selector, per-binding recording mode, conflict warnings (with override/swap/cancel), and per-binding reset functionality. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Unbound bindings (e.g., column navigation in Claude Code preset) now appear in the keybinding editor as rows with a muted em-dash instead of disappearing entirely. This ensures consistent layout across presets and lets users click to rebind unbound shortcuts. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…e docs 1. Fix SolidJS reactivity: replace produce() with full object replacement in setUserOverride/clearUserOverride so memos recompute correctly 2. Add "dismiss" text link to migration banner alongside the x button 3. Remove accidentally committed PRD, gitignore docs/ directory Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
User overrides are now stored per-preset instead of globally. Changing
a binding on Claude Code preset no longer affects Default, and vice
versa. Reset correctly clears only the active preset's overrides.
Persistence format updated to { preset, overridesByPreset: { ... } }
with backward compatibility for the old flat { userOverrides } format.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Previously, pressing Escape while in recording mode stopped event propagation, so the Dialog's own Escape handler never fired. Now Escape cancels recording without stopping propagation, allowing the dialog to close in a single keypress. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1. Fix modifiersMatch to treat cmdOrCtrl and meta as equivalent on macOS (and cmdOrCtrl/ctrl on Linux) so conflict detection works across app and terminal layers 2. Extract terminal binding filter into a function — avoids module-level createMemo (SolidJS lint) while keeping the hot path clean 3. Extract shared matchesKeyEvent utility (src/lib/keybindings/match.ts) used by both shortcuts.ts and TerminalView.tsx, removing duplicate key-matching logic 4. Replace native confirm() with app's styled dialog in Reset All Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
keybindings.jsonProblem
Parallel Code's shortcuts conflict with coding agents running inside its terminals. Option+Left/Right (word movement), Cmd+B (background task), and Cmd+Backspace (kill line) are intercepted or ignored, with no way to discover or fix these conflicts.
Claude Code preset resolves
Test plan
🤖 Generated with Claude Code